refactor(obfuscate): improve type consistency and simplify branch logic #1890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use tuple instead of set for value membership since values can be unhashable types (list, dict) - Revert obfuscate_string type signature to str only
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the obfuscate_sensitive_data function to improve performance and code maintainability through more efficient data structures and simplified control flow.
Changes:
- Converts list-based membership checks to sets for O(1) lookup performance on key checks
- Simplifies list iteration logic by directly checking for dict types instead of excluding all other types
- Removes obsolete pylint disable comment after branch reduction
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
obfuscate_sensitive_databy checking for dict directly instead of excluding other typesTest plan